-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel grid dimensions (40818x1) error fixed. #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is a big enough PR that I can’t give a decent review while traveling. My main question is if the overhead for the thread pool will slow down this request vs just making the requests in a loop.
Maybe Fred or Nate can take a look here.
Hello @alxmrs I tried with Code:
Image which tested:
Result:
Also tested on other images too and got the same result as above(taken ~21X more times). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this!
Fixed: #85.
The current code gives an error(
Pixel grid dimensions (40818x1) must be less than or equal to 32768
) when creating an lat, lon array for theimage_to_array
conversion, for certain lengthy images. To address this, I've made updates to the code. Now, when generating an lat, lon array for certain lengthy images, I break it down into smaller array based on Users preferred size or default size. This adjustment prevents the above error.